Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/card): use more specific selector for divider override #23531

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 4, 2021

Fixes that the card targets all dividers which may include ones placed inside child components.

Fixes #23524.

Fixes that the card targets all dividers which may include ones placed inside child components.

Fixes angular#23524.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Sep 4, 2021
@crisbeto crisbeto requested a review from jelbourn September 4, 2021 18:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 4, 2021
@crisbeto
Copy link
Member Author

crisbeto commented Sep 4, 2021

Caretaker note: this has a chance of screenshot failures if people didn't compose their card correctly.

@tmburnell
Copy link

I am the one that created the original issue, I want to point out one concern i had.
The fix above might break this case
image
because the divider is not a direct child of the mat-card, it is actually a child of the mat-list.
So i dont know if there needs to be an or so we dont break some people existing layouts.

@crisbeto
Copy link
Member Author

crisbeto commented Sep 7, 2021

I think that in that case the list should be the one responsible for the divider position.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 7, 2021
@Sergiobop
Copy link

Please merge this! Nice fix 👍

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin merged commit 0b52561 into angular:master Mar 16, 2022
zarend pushed a commit to zarend/components that referenced this pull request Mar 16, 2022
…ngular#23531)

Fixes that the card targets all dividers which may include ones placed inside child components.

Fixes angular#23524.
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ngular#23531)

Fixes that the card targets all dividers which may include ones placed inside child components.

Fixes angular#23524.
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ngular#23531)

Fixes that the card targets all dividers which may include ones placed inside child components.

Fixes angular#23524.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Dividers and Cards): Mat-Divider at any level in a Mat-Card is set to position absolute
6 participants