fix(material/core): ripples persisting when container is removed from DOM while fading-in #24482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
dev-app preview
devversion
force-pushed
the
fix/ripple-transition-cancel
branch
from
612e446 to
e6bd320
Compare
|
Deployed dev-app to: https://ng-comp-dev--pr-24482-1f322ebe91bc43d00bf3be825233c6d3-nifq49zm.web.app |
andrewseguin
approved these changes
Feb 25, 2022
devversion
requested review from
a team,
jelbourn and
crisbeto
as code owners
devversion
added
the
target: minor
crisbeto
reviewed
Feb 25, 2022
| // If the transition is cancelled (e.g. due to DOM removal), we destroy the ripple | ||
| // directly as otherwise we would keep it part of the ripple container forever. | ||
| // https://www.w3.org/TR/css-transitions-1/#:~:text=no%20longer%20in%20the%20document. | ||
| ripple.addEventListener('transitioncancel', () => this._destroyRipple(rippleRef)); |
There was a problem hiding this comment.
Should these event listeners be removed once the ripple is destroyed?
There was a problem hiding this comment.
good question. Not sure. If the ripple element is not referenced anywhere, it shouldn't matter?
… DOM while fading-in Follow-up to 65fb5f4. We recently changed how animations are handled in the ripple. As part of this change we accidentally broke the select <> ripple interaction. The select is special because the option panel is removed from the DOM as soon as an option got clicked. An option click will trigger a ripple that will usually still fade-in when the panel is removed. Currently such ripples never will complete because the `transitionend` event does not fire once removed from DOM. We should destroy the ripples when the transition is canceled (e.g. through DOM removal).
devversion
force-pushed
the
fix/ripple-transition-cancel
branch
from
e6bd320 to
1f322eb
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 65fb5f4.
We recently changed how animations are handled in the ripple. As part of this change
we accidentally broke the select <> ripple interaction. The select is special because
the option panel is removed from the DOM as soon as an option got clicked.
An option click will trigger a ripple that will usually still fade-in when the
panel is removed. Currently such ripples never will complete because the
transitionendevent does not fire once removed from DOM. We should destroy the ripples when the
transition is canceled (e.g. through DOM removal).