-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/input): resolve memory leak on iOS #24599
Merged
wagnermaciel
merged 1 commit into
angular:master
from
arturovt:fix/material-input-ios-listener
Mar 17, 2022
Merged
fix(material/input): resolve memory leak on iOS #24599
wagnermaciel
merged 1 commit into
angular:master
from
arturovt:fix/material-input-ios-listener
Mar 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Mar 16, 2022
crisbeto
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
action: merge
The PR is ready for merge by the caretaker
target: patch
This PR is targeted for the next patch release
labels
Mar 16, 2022
wagnermaciel
pushed a commit
that referenced
this pull request
Mar 17, 2022
(cherry picked from commit 0638419)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 27, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.0/13.3.1) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.0/13.3.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1331-pearl-necklace-2022-03-23) [Compare Source](angular/components@13.3.0...13.3.1) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [cf24b704d](angular/components@cf24b70) | fix | **schematics:** mark `ng-add` schematics as hidden | | [4a4ebe7df](angular/components@4a4ebe7) | perf | **scrolling:** do not run change detection if there are no `viewChange` listeners ([#​23987](angular/components#23987)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [0897f49d7](angular/components@0897f49) | fix | **autocomplete:** re-enter the Angular zone when the `NgZone.onStable` emits ([#​24569](angular/components#24569)) | | [51ddecbbb](angular/components@51ddecb) | fix | **checkbox:** model value not updated when using toggle method ([#​11902](angular/components#11902)) | | [174871713](angular/components@1748717) | fix | **input:** resolve memory leak on iOS ([#​24599](angular/components#24599)) | | [eed36b3ba](angular/components@eed36b3) | fix | **schematics:** mark `ng-add` schematics as hidden | | [240b238f9](angular/components@240b238) | fix | **select:** NVDA reading out table when opening select on Chrome ([#​23446](angular/components#23446)) | | [e04b7aeee](angular/components@e04b7ae) | fix | **select:** value set through property not being propagated to value accessor ([#​10246](angular/components#10246)) | | [5e5b296bf](angular/components@5e5b296) | perf | **icon:** remove IE workaround ([#​24514](angular/components#24514)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [b09c7427c](angular/components@b09c742) | fix | **mdc-chips:** replace innerText w/ textContent ([#​24635](angular/components#24635)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [0a3c7d7c4](angular/components@0a3c7d7) | fix | memory leak when forcing focus ([#​24520](angular/components#24520)) | #### Special Thanks Alan Agius, Artur Androsovych, CommanderRoot, Jeremy Elbourn, Joey Perrott, Kristiyan Kostadinov, Paul Gschwendtner, Wagner Maciel and tomicarsk6 <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1241 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding
keyup
event listener on iOS platforms, but never removed it.