-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/snack-bar): ensure that the snack bar always runs inside the NgZone #24611
Conversation
This change doesn't work well with internal tests because they are so aggressive with flushing. This causes snackbar's setTimeout to finish before they can check expectations on the displayed snackbar. Most tests can work around this by making sure they don't flush, but I wouldn't want to expect users to understand when and where they should feel safe flushing. See cl/437094895 for examples. I'm worried this will make it difficult for users to easily write tests for the snackbar. Is there another way this can be implemented, or is there another fix we could try for these client tests that would be more intuitive? |
… the NgZone Adds an extra call to ensure that the snack bar is inside the NgZone. This is something that has come up several times in internal tests where some API call is stubbed out, pulling the snack bar outside the zone and causing tests to fail when we remove a change detection somewhere. **Note:** I had a hard time reproducing this in our own tests, presumably because the fixture ends up pulling it back into the zone.
1acc15b
to
6ef3cd4
Compare
The calls outside the |
… the NgZone (#24611) Adds an extra call to ensure that the snack bar is inside the NgZone. This is something that has come up several times in internal tests where some API call is stubbed out, pulling the snack bar outside the zone and causing tests to fail when we remove a change detection somewhere. **Note:** I had a hard time reproducing this in our own tests, presumably because the fixture ends up pulling it back into the zone. (cherry picked from commit 99f1f38)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.1` -> `13.3.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.1/13.3.2) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.1` -> `13.3.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.1/13.3.2) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1332-flannel-flamingo-2022-03-30) [Compare Source](angular/components@13.3.1...13.3.2) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [48968719fc](angular/components@4896871) | fix | **a11y:** live announcer promise never resolved if new announcement comes in ([#​24700](angular/components#24700)) | | [e9734a9c66](angular/components@e9734a9) | fix | **testing:** entering negative number values not working with reactive forms ([#​24656](angular/components#24656)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [c677f11ed8](angular/components@c677f11) | fix | **button-toggle:** ripples not clipping correctly in safari ([#​12311](angular/components#12311)) | | [20af3e7c9d](angular/components@20af3e7) | fix | **chips:** ripple not clipped on safari ([#​21495](angular/components#21495)) | | [d04e7c9b69](angular/components@d04e7c9) | fix | **core:** unable to override tag selectors inside .mat-typography ([#​14617](angular/components#14617)) | | [9490a31641](angular/components@9490a31) | fix | **list:** not working correctly when list item is used as a button ([#​13617](angular/components#13617)) | | [b07ae4ccc4](angular/components@b07ae4c) | fix | **menu:** clicks on disabled item closing the menu ([#​19183](angular/components#19183)) | | [e85777712a](angular/components@e857777) | fix | **radio:** set tabindex based on selected state ([#​18081](angular/components#18081)) | | [7f274dc96f](angular/components@7f274dc) | fix | **snack-bar:** ensure that the snack bar always runs inside the NgZone ([#​24611](angular/components#24611)) | | [a5aa87502b](angular/components@a5aa875) | fix | **tabs:** focus wrapping back to selected label when using shift + tab ([#​14194](angular/components#14194)) | | [04f4937b75](angular/components@04f4937) | fix | **tabs:** update tab state when active tab is swapped out ([#​24164](angular/components#24164)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [a704913d2b](angular/components@a704913) | fix | **mdc-button:** extended fab touch target not covering entire button ([#​24322](angular/components#24322)) | | [23e7b8e6c1](angular/components@23e7b8e) | fix | **mdc-chips:** make it easier to customize chip typography ([#​24632](angular/components#24632)) | | [518022288b](angular/components@5180222) | fix | **mdc-chips:** Mirror aria-describedby to matChipInput ([#​24551](angular/components#24551)) | | [9497b02f8b](angular/components@9497b02) | fix | **mdc-slider:** update layout when container resizes ([#​24648](angular/components#24648)) | | [e5c025dff4](angular/components@e5c025d) | fix | **mdc-slider:** use passive event listeners ([#​24675](angular/components#24675)) | #### Special Thanks Artur Androsovych, ByzantineFailure, David Gonzalez, Dilyorbek, Kristiyan Kostadinov, Naveen, Paul Gschwendtner, Raí Siqueira, Shivam Sethi, Wagner Maciel and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1275 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
… the NgZone (angular#24611) Adds an extra call to ensure that the snack bar is inside the NgZone. This is something that has come up several times in internal tests where some API call is stubbed out, pulling the snack bar outside the zone and causing tests to fail when we remove a change detection somewhere. **Note:** I had a hard time reproducing this in our own tests, presumably because the fixture ends up pulling it back into the zone.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds an extra call to ensure that the snack bar is inside the NgZone. This is something that has come up several times in internal tests where some API call is stubbed out, pulling the snack bar outside the zone and causing tests to fail when we remove a change detection somewhere.
Note: I had a hard time reproducing this in our own tests, presumably because the fixture ends up pulling it back into the zone.