feat(material/slide-toggle): Add disabled predicate to MatSlideToggleHarness
#24761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
reviewed
Apr 11, 2022
There was a problem hiding this comment.
Good addition, just needs a few small things:
- Make a similar change to the mdc-based harness (they're separate implementations)
- Add a unit test to
slide-toggle-harness.spec.ts(we have separate component tests and component harness tests) - Run
yarn approve-api slide-toggleto update the public API gold
DONE
DONE
DONE, .. I think?. This didn't appear to do anything interesting. Update: I figured it out now ;P |
richieforeman
force-pushed
the
rf/slide-toggle-harness
branch
3 times, most recently
from
317f07a to
4cef1b3
Compare
crisbeto
reviewed
Apr 12, 2022
src/material/slide-toggle/testing/slide-toggle-harness-filters.ts
Outdated
Show resolved
Hide resolved
richieforeman
force-pushed
the
rf/slide-toggle-harness
branch
from
4cef1b3 to
3f0b534
Compare
…leHarness - Add `disabled` predicate to MatMdcSlideToggleHarness - Update tests for new `disabled` predicate - Update golden
richieforeman
force-pushed
the
rf/slide-toggle-harness
branch
from
3f0b534 to
2d96925
Compare
devversion
approved these changes
Apr 12, 2022
crisbeto
added
P3
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabledpredicate to MatSlideToggleHarness