fix(material/autocomplete): apply theme of parent form field to panel #25983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
target: minor
zarend
force-pushed
the
autocomplete-theme-color
branch
from
ca45c69 to
862c1de
Compare
crisbeto
reviewed
Nov 15, 2022
zarend
force-pushed
the
autocomplete-theme-color
branch
from
862c1de to
a9b34c9
Compare
|
@crisbeto I've responded to PR comments, and this is ready for your eyes again 👀 |
mmalerba
approved these changes
Nov 15, 2022
| @@ -122,6 +123,14 @@ export abstract class _MatAutocompleteBase | |||
| } | |||
| _isOpen: boolean = false; | |||
|
|
|||
| /** Sets the theme color of the panel. @docs-private */ | |||
There was a problem hiding this comment.
nit: put jsdoc tag at beginning of the line:
@docs-private Sets the theme color of the panel.
zarend
force-pushed
the
autocomplete-theme-color
branch
from
a9b34c9 to
e6f1045
Compare
Apply the theme of the autocomplete's parent form field to its panel. Fix issue where theme color only applies to the input, and does not affect the panel.
zarend
force-pushed
the
autocomplete-theme-color
branch
from
e6f1045 to
4f55dae
Compare
|
Fixed crash when formField is null 🤦 . |
|
I sent out #26009 to improve typing to help prevent further mistakes when injected properties are null. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the theme of the autocomplete's parent form field to its panel. Fix issue where theme color only applies to the input, and does not affect the panel.