Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): implement ariaDescription with aria-describedby #26105

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix(material/chips): implement ariaDescription with aria-describedby #26105

merged 1 commit into from
Dec 9, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Nov 28, 2022

For the ariaDescription Input, implement with aria-describedby rather than aria-description. aria-description is still in W3C Editor's Draft for ARIA 1.3.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release area: material/chips labels Nov 28, 2022
@zarend zarend mentioned this pull request Nov 28, 2022
Merged
@zarend
Copy link
Contributor Author

zarend commented Nov 28, 2022

cc @christiangil0

@zarend zarend force-pushed the refactor-aria-description branch from 741ecb1 to a1862f3 Compare November 28, 2022 18:34
@zarend zarend requested a review from andrewseguin as a code owner November 28, 2022 18:34
@zarend zarend self-assigned this Nov 28, 2022
mmalerba
mmalerba reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some CI issues

@zarend zarend force-pushed the refactor-aria-description branch 4 times, most recently from 357f525 to 5341bc4 Compare December 5, 2022 19:40
@zarend zarend requested a review from mmalerba December 5, 2022 20:15
@zarend
Copy link
Contributor Author

zarend commented Dec 5, 2022

@mmalerba @crisbeto , CI is passing, and this is ready for your eyes 👀

@zarend
fix(material/chips): implement ariaDescription with aria-describedby
a781583 
For the `ariaDescription` Input, implement with aria-describedby rather
than aria-description. aria-description is still in W3C Editor's Draft for ARIA
1.3.
@zarend zarend force-pushed the refactor-aria-description branch from 5341bc4 to a781583 Compare December 6, 2022 18:18
@zarend zarend requested a review from crisbeto December 6, 2022 18:18
crisbeto
crisbeto approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2022
@zarend zarend merged commit dcf2fac into angular:main Dec 9, 2022
@zarend zarend deleted the refactor-aria-description branch December 9, 2022 01:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@zarend zarend

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/chips target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarend @crisbeto @mmalerba