fix(slider): hide ticks when slider is disabled

[devversion]

• No longer shows the ticks on hover when the slider is disabled.

[jelbourn]

This TODO was actually referring to something else. If you look at the spec, you'll see that there's a tiny empty space around the thumb that covers up the track when the slider is disabled; this is talking about that.

[devversion]

Isn't that already implemented? (I probably miss something)

[jelbourn]

Oh, I didn't realize.

[jelbourn]

LGTM

[mmalerba]

It looks like this causes non-disabled sliders to not render the last tick. Make sure to rebase on top of #2641 it adds some more corner cases to watch out for.

Please include me as a reviewer on slider PRs in the future.

[devversion]

@mmalerba Yeah I locally tested this PR with your PR #2641 but at this time it wasn't merged yet (will rebase it today)

Also from looking at the diff, there hasn't been any change for tick sequencing. It only hides the .md-slider-ticks class when a slider is disabled?

And yes can assign you to future slider PR's

[mmalerba]

I think the css rule precedence started getting unwieldy so I added a md-hide-last-tick class, you could probably just add || disabled to the condition for that class

[devversion]

@mmalerba Updated everything as discussed on Slack.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}