fix(slide-toggle): consistent naming of aria attributes #2688
Conversation
devversion
commented
Jan 17, 2017
devversion
commented
- Ensures that the slide-toggle uses consistent attribute naming.
* Ensures that the slide-toggle uses consistent attribute naming. Consistent with the native inputs and other Material components.
googlebot
added
the
cla: yes
| @@ -83,13 +83,13 @@ export class MdSlideToggle implements AfterContentInit, ControlValueAccessor { | |||
| @Input() id: string = this._uniqueId; | |||
|
|
|||
| /** Used to specify the tabIndex value for the underlying input element. */ | |||
| @Input() tabIndex: number = 0; | |||
| @Input() tabindex: number = 0; | |||
There was a problem hiding this comment.
It should be tabIndex, as that's the name of the property on native elements.
(e.g., with an input you'd do <input [tabIndex]="...">)
There was a problem hiding this comment.
But if we change the @Input() to tabIndex then using tabindex as a normal HTML attribute won't work anymore?
Thought about doing
@Input('tabindex') tabIndexbut that doesn't cover both cases.
Also we currently have
tabindexfor the deprecated input right now.
There was a problem hiding this comment.
@jelbourn Changed it back to tabIndex, because I think that the consistency with the HTMLElement property is more weighted than the tabindex attribute.
Didn't change it for the deprecated input component, because making some breaking changes on something that's deprecated feels wrong.
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
* fix(slide-toggle): consistent naming of aria attributes * Ensures that the slide-toggle uses consistent attribute naming. Consistent with the native inputs and other Material components. * Change back to tabIndex
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
