Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/slide-toggle): add cursor pointer for label #27391

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jun 30, 2023

our label in slider doesn't contain cursor pointer style as we can still click on label and toggle slider

fixes #26490

@naaajii naaajii requested a review from crisbeto as a code owner June 30, 2023 12:34
@amysorto amysorto self-assigned this Jun 30, 2023
@naaajii
Copy link
Contributor Author

naaajii commented Jul 2, 2023

is this a breaking change? should the commit include a breaking change format? @crisbeto

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a breaking change, but the commit message has to be updated to mention the slide toggle, not the slider.

src/material/slide-toggle/slide-toggle.scss Outdated Show resolved Hide resolved
our label in slider doesn't contain cursor pointer style as we can still click on label and toggle slider

fixes angular#26490
@naaajii naaajii changed the title fix(material/slider): add cursor pointer for label fix(material/slide-toggle): add cursor pointer for label Jul 2, 2023
@naaajii
Copy link
Contributor Author

naaajii commented Jul 2, 2023

thank you for clearing the doubt! I'm not sure how I missed it such an obvious mistake. 😅

@naaajii naaajii requested a review from crisbeto July 8, 2023 11:14
@crisbeto crisbeto assigned crisbeto and unassigned amysorto Jul 16, 2023
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jul 16, 2023
@crisbeto crisbeto merged commit 6bbf2ea into angular:main Jul 17, 2023
crisbeto pushed a commit that referenced this pull request Jul 17, 2023
our label in slider doesn't contain cursor pointer style as we can still click on label and toggle slider

fixes #26490

(cherry picked from commit 6bbf2ea)
AnthonyFr75 pushed a commit to AnthonyFr75/components that referenced this pull request Jul 31, 2023
our label in slider doesn't contain cursor pointer style as we can still click on label and toggle slider

fixes angular#26490
stephenrca pushed a commit to stephenrca/components that referenced this pull request Aug 2, 2023
our label in slider doesn't contain cursor pointer style as we can still click on label and toggle slider

fixes angular#26490
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2023
@naaajii naaajii deleted the fix-26490 branch September 27, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(slide-toggle): wrong cursor on label
3 participants