fix(material/radio): clear selected radio button from group #27466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P4
crisbeto
force-pushed
the
27461/radio-remove-selected
branch
from
df06dfc to
2bbd327
Compare
In angular#18081 the radio group was changed so that deselected buttons receive `tabindex="-1"` when there's a selected button. The problem is that we weren't clearing the reference to the selected button so it gets removed, the deselected buttons become unfocusable using the keyboard. These changes clear the selected radio button on destroy. Fixes angular#27461.
crisbeto
force-pushed
the
27461/radio-remove-selected
branch
from
2bbd327 to
0d060c5
Compare
andrewseguin
approved these changes
Jul 16, 2023
crisbeto
added a commit
that referenced
this pull request
Jul 17, 2023
In #18081 the radio group was changed so that deselected buttons receive `tabindex="-1"` when there's a selected button. The problem is that we weren't clearing the reference to the selected button so it gets removed, the deselected buttons become unfocusable using the keyboard. These changes clear the selected radio button on destroy. Fixes #27461. (cherry picked from commit 6c846e2)
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
…27466) In angular#18081 the radio group was changed so that deselected buttons receive `tabindex="-1"` when there's a selected button. The problem is that we weren't clearing the reference to the selected button so it gets removed, the deselected buttons become unfocusable using the keyboard. These changes clear the selected radio button on destroy. Fixes angular#27461.
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
…27466) In angular#18081 the radio group was changed so that deselected buttons receive `tabindex="-1"` when there's a selected button. The problem is that we weren't clearing the reference to the selected button so it gets removed, the deselected buttons become unfocusable using the keyboard. These changes clear the selected radio button on destroy. Fixes angular#27461.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18081 the radio group was changed so that deselected buttons receive
tabindex="-1"when there's a selected button. The problem is that we weren't clearing the reference to the selected button so it gets removed, the deselected buttons become unfocusable using the keyboard.These changes clear the selected radio button on destroy.
Fixes #27461.