Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/theming): add M3 sidenav support #28125

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 15, 2023
@mmalerba mmalerba requested a review from devversion as a code owner November 15, 2023 00:41
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 15, 2023
@if inspection.get-theme-version($theme) == 1 {
@include _theme-from-tokens(inspection.get-theme-tokens($theme, density));
}
@else {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we remove the empty @else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it to make it clear where M2 styles should go, but if we don't like it we can make a PR to clean it up across all components

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2023
@angular-robot angular-robot bot requested a review from crisbeto November 16, 2023 20:35
@mmalerba mmalerba removed the request for review from crisbeto November 16, 2023 20:49
@angular-robot angular-robot bot requested a review from crisbeto November 16, 2023 20:51
@mmalerba mmalerba removed the request for review from crisbeto November 16, 2023 20:55
@mmalerba mmalerba merged commit 603f550 into angular:main Nov 16, 2023
22 of 24 checks passed
mmalerba added a commit that referenced this pull request Nov 16, 2023
* feat(material-experimental/theming): add M3 list support

* feat(material-experimental/theming): add M3 sidenav support

(cherry picked from commit 603f550)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants