feat(material-experimental/theming): add M3 icon support #28126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Nov 15, 2023
| @if inspection.get-theme-version($theme) == 1 { | ||
| @include _theme-from-tokens(inspection.get-theme-tokens($theme, density)); | ||
| } | ||
| @else {} |
There was a problem hiding this comment.
nit: should we drop the empty @else here and above?
There was a problem hiding this comment.
Same answer as the other PR, I left it to signal where M2 styles should go. but we can go remove it across all components that have it if we don't think its helpful
mmalerba
added a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 4d50c38)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.