Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): add transition to focus overlay #2850

Merged
merged 1 commit into from
Feb 17, 2017
Merged

fix(button): add transition to focus overlay #2850

merged 1 commit into from
Feb 17, 2017

Conversation

devversion
Copy link
Member

  • Adds a transition to the button focus overlay -It still shows up very fast, it just feels a bit smoother (similar as in MDL and M1)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 28, 2017
@devversion devversion assigned tinayuangao and unassigned jelbourn Feb 5, 2017
tinayuangao
tinayuangao approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 7, 2017
@devversion
fix(button): add transition to focus overlay
1e1fac2 
* Adds a transition to the button focus overlay -It still shows up very fast, it just feels a bit smoother (similar as in MDL and M1)
@andrewseguin andrewseguin merged commit 6cdd8db into angular:master Feb 17, 2017
@devversion devversion deleted the fix/button-hover-transition branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @tinayuangao @jelbourn @googlebot @andrewseguin