feat(sidenav): open all sidenavs from MdSidenavContainer #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 30, 2017
src/lib/sidenav/sidenav.ts
Outdated
| } | ||
|
|
||
| return Promise.all(promises); | ||
| } |
mmalerba
reviewed
Jan 31, 2017
src/lib/sidenav/sidenav.ts
Outdated
| @@ -367,6 +367,36 @@ export class MdSidenavContainer implements AfterContentInit { | |||
| this._validateDrawers(); | |||
| } | |||
|
|
|||
| /** Calls `open` of both start and end sidenavs */ | |||
| public open() { | |||
| const promises: Promise<MdSidenavToggleResult>[] = []; | |||
There was a problem hiding this comment.
can't this be simplified to:
return Promise.all([this._start, this._end].map((sidenav) => sidenav && sidenav.open()));
There was a problem hiding this comment.
Thanks that's much simpler
EladBezalel
force-pushed
the
feat/multiple-sidenav-open
branch
from
4cdb828
to
a4071e9
Compare
EladBezalel
force-pushed
the
feat/multiple-sidenav-open
branch
from
a4071e9
to
1d6449b
Compare
- added `open` and `close` functions that applies to both sidenavs in the container and resolves when both are finished fixes angular#2591
EladBezalel
force-pushed
the
feat/multiple-sidenav-open
branch
from
1d6449b
to
b4fdcc8
Compare
|
@mmalerba is this merge-ready? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openandclosefunctions that applies to both sidenavs in the container and resolves when both are finishedfixes #2591