Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): leaking component instance references #2875

Merged
merged 1 commit into from
Mar 17, 2017
Merged

fix(dialog): leaking component instance references #2875

merged 1 commit into from
Mar 17, 2017

Commits on Mar 16, 2017

  1. fix(dialog): leaking component instance references 

    Fixes a memory leak in the dialog, which was causing it to keep references to the user's instantiated dialog in memory forever. It was due to:
1. The portal class wasn't invoking the cleanup function if it didn't have attached content.
2. The dialog ref was keeping the reference after the dialog is closed. There is also a leak related to dialog refs which will be addressed separately.

Fixes angular#2734.
    @crisbeto
    crisbeto committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    afc8d8b View commit details
    Browse the repository at this point in the history