feat(datepicker): add month & year view #2904

mmalerba · 2017-02-02T19:44:57Z

No description provided.

tinayuangao · 2017-02-02T20:03:39Z

src/lib/core/datetime/simple-date.spec.ts

+  });
+
+  it('handles month and date underflow', () => {
+    expect(new SimpleDate(2017, -1, 0)).toEqual(new SimpleDate(2016, 10, 30));


Is it (2016, 10, 31)?

The months are 0-indexed to match native JS Dates, so 10 = November. I considered using 1-indexed because it make more sense, but I thought it was better to just stay consistent with what people already know. I'll add a note about the 0-indexing to the SimpleDate docs.

tinayuangao · 2017-02-02T23:36:04Z

src/lib/datepicker/calendar-table.spec.ts

+    });
+
+    it('highlights selected', () => {
+      let todayCell = calendarTableNativeElement.querySelector('.mat-calendar-table-selected');


very nit: selectedCell?

tinayuangao · 2017-02-02T23:41:56Z

src/lib/datepicker/month-view.spec.ts

+    TestBed.compileComponents();
+  }));
+
+  describe('standard year view', () => {


nit: standard month view

tinayuangao · 2017-02-02T23:50:25Z

src/lib/datepicker/month-view.ts

+   * The date of the month that the currently selected Date falls on.
+   * Null if the currently selected Date is in another month.
+   */
+  _selectedDate = 0;


Do we want to set default value to null?
Add type for this variable?

tinayuangao · 2017-02-03T00:39:11Z

src/lib/datepicker/year-view.ts

+
+  constructor(private _locale: CalendarLocale) {
+    // First row of months only contains 5 elements so we can fit the year label on the same row.
+    this._months = [[0, 1, 2, 3, 4], [5, 6, 7, 8, 9, 10, 11]].map(row => row.map(


months value should start from 0 or 1? could you please add some docs?

tinayuangao

LGTM

tinayuangao · 2017-02-03T23:10:26Z

src/lib/core/datetime/simple-date.ts

+    return this._date.getMonth();
+  }
+
+  /** The date component of this date. */


nit: Also add doc about date index?

kara

Nits

kara · 2017-02-07T17:47:14Z

src/lib/core/datetime/simple-date.ts

  static fromNativeDate(nativeDate: Date) {
    return new SimpleDate(nativeDate.getFullYear(), nativeDate.getMonth(), nativeDate.getDate());
  }

-  constructor(public year: number, public month: number, public date: number) {}
+  /** Creates a SimpleDate object representing today. */
+  static today() {


Return type? Same for methods below.

kara · 2017-02-07T17:50:12Z

src/lib/datepicker/calendar-table.scss

+
+.mat-calendar-table-label {
+  height: $mat-calendar-table-cell-content-size;
+  padding: 0 0 0 10px;


Nit: Sass variable for 10px? Seems like the only one missing.

kara · 2017-02-07T17:53:49Z

src/lib/datepicker/calendar-table.spec.ts

+      expect(labelEls.length).toBe(1);
+      expect(cellEls.length).toBe(11);
+      expect(rowEls[0].firstElementChild.classList.contains('mat-calendar-table-label')).toBe(
+          true, 'first cell should be the label');


This might be a bit more readable if you use toContain() assertion

expect(rowEls[0].firstElementChild.classList) .toContain('mat-calendar-table-label', 'First cell should be the label.');

kara · 2017-02-07T18:05:01Z

src/lib/datepicker/month-view.ts

+    this._date = this._locale.parseDate(value) || SimpleDate.today();
+    this._init();
+  }
+  private _date = SimpleDate.today();


Can you stack all the private properties at the top of the class? That's typically the format we use in other components so it's easy to find them.

When it's acting as backing for a public property with a getter/setter isn't it nicer to have it next to its getter/setter?

* date picker initial commit * month view * added month view functionality * more month view tweaking * started extracting common stuff to calendar-table. * base month view on calendar table * added year view * add disclaimers * addressed comments * fix lint * fixed aot and added comment * started on tests * calendar table tests * tests for month and year view * rebase on top of CalendarLocale & SimpleDate * add some additional functionality to SimpleDate * fix lint * addressed comments * add comment

angular-automatic-lock-bot · 2019-09-06T08:01:27Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

mmalerba added 17 commits February 2, 2017 09:16

date picker initial commit

97c212f

month view

304f4e4

added month view functionality

35ec1a5

more month view tweaking

2e78102

started extracting common stuff to calendar-table.

bcdb462

base month view on calendar table

102d483

added year view

1b3ff7b

add disclaimers

6f2217c

addressed comments

85f0464

fix lint

35b8a9d

fixed aot and added comment

1aabacc

started on tests

81f587a

calendar table tests

7b5e4ba

tests for month and year view

52cee53

rebase on top of CalendarLocale & SimpleDate

07b3080

add some additional functionality to SimpleDate

3914d1d

fix lint

2d6b58f

mmalerba added the pr: needs review label Feb 2, 2017

mmalerba assigned kara and tinayuangao Feb 2, 2017

mmalerba requested review from kara and tinayuangao February 2, 2017 19:44

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 2, 2017

tinayuangao reviewed Feb 3, 2017

View reviewed changes

addressed comments

38c5a9a

tinayuangao reviewed Feb 3, 2017

View reviewed changes

add comment

e3c0dae

kara approved these changes Feb 7, 2017

View reviewed changes

kara added pr: lgtm and removed pr: needs review labels Feb 7, 2017

kara assigned mmalerba Feb 7, 2017

mmalerba merged commit 3e88d46 into angular:datepicker Feb 7, 2017

mmalerba added a commit to mmalerba/components that referenced this pull request Feb 8, 2017

fixes i forgot to push before merging angular#2904

80edc80

mmalerba added a commit that referenced this pull request Feb 8, 2017

fixes i forgot to push before merging #2904 (#2978)

13180fa

mmalerba added a commit to mmalerba/components that referenced this pull request Feb 9, 2017

fixes i forgot to push before merging angular#2904 (angular#2978)

957e0d9

mmalerba added a commit that referenced this pull request Feb 9, 2017

fixes i forgot to push before merging #2904 (#2978)

98b7fbc

mmalerba added a commit that referenced this pull request Feb 27, 2017

fixes i forgot to push before merging #2904 (#2978)

b2fe61f

mmalerba added a commit that referenced this pull request Mar 2, 2017

fixes i forgot to push before merging #2904 (#2978)

45d09f4

mmalerba added a commit to mmalerba/components that referenced this pull request Mar 6, 2017

fixes i forgot to push before merging angular#2904 (angular#2978)

9bf5e10

mmalerba added a commit that referenced this pull request Mar 17, 2017

fixes i forgot to push before merging #2904 (#2978)

2ca17b4

mmalerba added a commit to mmalerba/components that referenced this pull request Mar 28, 2017

fixes i forgot to push before merging angular#2904 (angular#2978)

206051a

mmalerba added a commit that referenced this pull request Apr 14, 2017

fixes i forgot to push before merging #2904 (#2978)

6d4ece4

mmalerba added a commit that referenced this pull request Apr 20, 2017

fixes i forgot to push before merging #2904 (#2978)

d9c7f0b

mmalerba added a commit that referenced this pull request Apr 29, 2017

fixes i forgot to push before merging #2904 (#2978)

9f8b4ac

mmalerba added a commit that referenced this pull request May 5, 2017

fixes i forgot to push before merging #2904 (#2978)

f1a6adc

mmalerba added a commit that referenced this pull request May 9, 2017

fixes i forgot to push before merging #2904 (#2978)

fc34721

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datepicker): add month & year view #2904

feat(datepicker): add month & year view #2904

mmalerba commented Feb 2, 2017

tinayuangao Feb 2, 2017

mmalerba Feb 3, 2017

tinayuangao Feb 2, 2017

tinayuangao Feb 2, 2017

tinayuangao Feb 2, 2017

tinayuangao Feb 3, 2017

tinayuangao left a comment

tinayuangao Feb 3, 2017

kara left a comment

kara Feb 7, 2017

kara Feb 7, 2017

kara Feb 7, 2017

kara Feb 7, 2017

mmalerba Feb 7, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

feat(datepicker): add month & year view #2904

feat(datepicker): add month & year view #2904

Conversation

mmalerba commented Feb 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tinayuangao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kara left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 6, 2019