feat(multiple): fallback to system level variables #29480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
force-pushed
the
theme-exp
branch
6 times, most recently
from
4901740 to
3f368a5
Compare
andrewseguin
changed the title
andrewseguin
requested review from
crisbeto,
amysorto,
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
force-pushed
the
theme-exp
branch
2 times, most recently
from
8c4b151 to
af430cf
Compare
andrewseguin
added
target: minor
crisbeto
reviewed
Jul 30, 2024
crisbeto
approved these changes
Jul 30, 2024
amysorto
approved these changes
Jul 31, 2024
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
themeAPI that takes the theme-config and emits system-level CSS variables. Component tokens will fallback to these system-level variables, removing the need to call component-specific mixins and setting fine-grained tokens.This
themeAPI is not exposed, because hardcoded values still fallback to M2 values in some cases. This will need to be updated before this API can be used, but it will require updating a number of internal screenshots. This will be a follow-up change before addingthemeto theindex.scss.