Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): change fallbacks to use m3 #29528

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jul 31, 2024

When possible, use token fallbacks defined by the MDC system tokens instead of the M2 hardcoded values (or nothing).

This will affect the appearance of applications that are incorrectly lacking calls to component theme mixins, since all of these fallbacks should be ignored in favor of the fine-grained token values.

Applications that have styles changed from this should ensure that they are calling component theme mixins, e.g. mat.button-theme() if a button is used.

For example, here's the change for expansion panel expanded height:

.mat-expansion-panel-header.mat-expanded {
    // Before: 
    height: var(--mat-expansion-header-expanded-state-height);

    // After:
    height: var(--mat-expansion-header-expanded-state-height, 64px);
}

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Jul 31, 2024
@andrewseguin andrewseguin requested a review from a team as a code owner July 31, 2024 22:22
@andrewseguin andrewseguin requested review from amysorto, mmalerba and wagnermaciel and removed request for a team July 31, 2024 22:22
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 16, 2024
@wagnermaciel wagnermaciel removed the request for review from mmalerba August 21, 2024 21:04
@wagnermaciel wagnermaciel merged commit cb1450f into angular:main Aug 21, 2024
20 of 22 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants