Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/icon): update error message for missing HttpClient #29589

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

crisbeto
Copy link
Member

Updates the message saying that HttpClient is missing to refer to a non-deprecated API.

Fixes #29587.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 15, 2024
@crisbeto crisbeto requested a review from a team as a code owner August 15, 2024 07:59
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team August 15, 2024 07:59
Updates the message saying that `HttpClient` is missing to refer to a non-deprecated API.

Fixes angular#29587.
@crisbeto crisbeto force-pushed the 29587/icon-error-message branch from 8ea7309 to 7d9a30f Compare August 15, 2024 08:03
@crisbeto crisbeto removed the request for review from amysorto August 15, 2024 14:25
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 15, 2024
@crisbeto crisbeto merged commit 4f2bc4d into angular:main Aug 15, 2024
21 of 24 checks passed
crisbeto added a commit that referenced this pull request Aug 15, 2024
Updates the message saying that `HttpClient` is missing to refer to a non-deprecated API.

Fixes #29587.

(cherry picked from commit 4f2bc4d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatIconRegistry): Change error message to not suggest a deprecated component, HttpClientModule.
2 participants