fix(multiple): account for mixed declarations in latest Sass version #29596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto,
wagnermaciel and
andrewseguin
and removed request for
a team
crisbeto
force-pushed
the
29591/sass-warning
branch
2 times, most recently
from
f3e7a14
to
367486b
Compare
1 task
crisbeto
added
target: major
crisbeto
force-pushed
the
29591/sass-warning
branch
from
367486b
to
0752d8b
Compare
Fixes a ton of warnings that showed up in the latest version of Sass as a result of https://sass-lang.com/documentation/breaking-changes/mixed-decls/. BREAKING CHANGE: * In order for Material to be compatible with [recent changes in Sass](https://sass-lang.com/documentation/breaking-changes/mixed-decls/) and upcoming changes in the CSS standard, tokens are now emitted in-place, rather the being hoisted to the top of the selector. As a result, some token overrides might not apply anymore. This is relevant primarily for the cases like `@include mat.button-theme($theme); --mat-button-color: red;`. It can be resolved by wrapping the overrides with `& {}`, for example `@include mat.button-theme($theme); & { --mat-button-color: red; }`. Fixes angular#29591.
crisbeto
force-pushed
the
29591/sass-warning
branch
from
0752d8b
to
e6a0f28
Compare
angular-robot
bot
added
the
detected: breaking change
andrewseguin
approved these changes
Aug 20, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a ton of warnings that showed up in the latest version of Sass as a result of https://sass-lang.com/documentation/breaking-changes/mixed-decls/.
BREAKING CHANGE:
@include mat.button-theme($theme); --mat-button-color: red;. It can be resolved by wrapping the overrides with& {}, for example@include mat.button-theme($theme); & { --mat-button-color: red; }.Fixes #29591.