Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): make calendar look more like mocks #3138

Merged
merged 3 commits into from
Feb 17, 2017

Conversation

mmalerba
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

color: mat-color($primary, default-contrast);
}

.mat-calendar-table-today {
border-color: mat-color($foreground, divider);
&:not(.mat-calendar-table-selected) {
// Note: though its not text, the border is a hint about the fact that this is today's date,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: its -> it's

$mat-calendar-padding: 8px !default;
$mat-calendar-header-divider-width: 1px !default;
$mat-calendar-controls-vertical-padding: 5%;
$mat-calendar-controls-start-padding: calc(100% / 14 - 6px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for this? The numbers look a bit opaque

@kara kara removed their assignment Feb 16, 2017
@mmalerba mmalerba merged commit 03e816d into angular:datepicker Feb 17, 2017
@mmalerba mmalerba deleted the dp branch February 17, 2017 20:23
mmalerba added a commit that referenced this pull request Feb 27, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request Mar 2, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit to mmalerba/components that referenced this pull request Mar 6, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request Mar 17, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit to mmalerba/components that referenced this pull request Mar 28, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request Apr 14, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request Apr 20, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request Apr 29, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request May 5, 2017
* style changes

* more styles

* addressed comments
mmalerba added a commit that referenced this pull request May 9, 2017
* style changes

* more styles

* addressed comments
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants