feat(datepicker): min & max dates + dateFilter #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Mar 14, 2017
src/lib/core/datetime/simple-date.ts
Outdated
| * @param max The maximum date | ||
| * @returns A new SimpleDate equal to this one clamped between the given min and max dates. | ||
| */ | ||
| clamp(min: SimpleDate, max: SimpleDate) { |
src/lib/datepicker/calendar.ts
Outdated
| /** | ||
| * A date representing the current period shown in the calendar. The current period is always | ||
| * normalized to the 1st of a month, this prevents date overflow issues (e.g. adding a month to | ||
| * January 31st and overflowing into March). | ||
| */ | ||
| get _currentPeriod() { return this._normalizedCurrentPeriod; } | ||
| set _currentPeriod(value: SimpleDate) { | ||
| this._normalizedCurrentPeriod = new SimpleDate(value.year, value.month, 1); | ||
| let clampedValue = value.clamp(this.minDate, this.maxDate); |
src/lib/datepicker/year-view.ts
Outdated
| let enabled = false; | ||
| for (let date = new SimpleDate(this.date.year, month, 1); date.month === month; | ||
| date = date.add({days: 1})) { | ||
| enabled = enabled || this.dateFilter(date); |
There was a problem hiding this comment.
Do you need the enabled || check? Looks like if it's enabled, it will break the loop anyway.
mmalerba
added a commit
that referenced
this pull request
Mar 17, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Mar 28, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
that referenced
this pull request
Apr 14, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
that referenced
this pull request
Apr 20, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
that referenced
this pull request
Apr 29, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
that referenced
this pull request
May 5, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
mmalerba
added a commit
that referenced
this pull request
May 9, 2017
* don't allow going past min/max date * add back missing mdSuffix * added date filtering logic * added working date filter * disabled style for prev/next buttons * add unit tests * fix lint * address comments
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.