Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): not scrolling to active option when pressing home/end #3709

Merged
merged 1 commit into from
Apr 18, 2017
Merged

fix(autocomplete): not scrolling to active option when pressing home/end #3709

merged 1 commit into from
Apr 18, 2017

Conversation

crisbeto
Copy link
Member

  • Fixes the autocomplete not scrolling to active items that were highlighted by pressing home or end.
  • Switches up the logic to scroll to any newly-focused options. This should make it more future-proof, if we add more shortcuts to the key manager.

Relates to #3496.

@crisbeto
fix(autocomplete): not scrolling to active option when pressing home/end
3957b8b 
* Fixes the autocomplete not scrolling to active items that were highlighted by pressing `home` or `end`.
* Switches up the logic to scroll to any newly-focused options. This should make it more future-proof, if we add more shortcuts to the key manager.

Relates to angular#3496.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 21, 2017
kara
kara approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 18, 2017
@kara kara removed their assignment Apr 18, 2017
@kara kara merged commit 8d0cd04 into angular:master Apr 18, 2017
@stgeorge
Copy link

I don't think this "resolves" 3496... the home/end keys should act like home/end keys while on the input string. Right now they are blocked which should never happen.

@crisbeto
Copy link
Member Author

I haven't mentioned anywhere that this should resolve #3496 @stgeorge, however #4544 should.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @stgeorge @kara @googlebot