Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): use input's min & max properites rather than custom … #3854

Merged
merged 2 commits into from
Mar 30, 2017

Conversation

mmalerba
Copy link
Contributor

…ones on md-datepicker

@mmalerba mmalerba requested a review from kara March 30, 2017 19:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 30, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -61,6 +63,16 @@ export class MdDatepickerInput implements AfterContentInit, ControlValueAccessor
@Input()
set matDatepicker(value: MdDatepicker) { this.mdDatepicker = value; }

@Input()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for these @inputs? For docs site.

@kara kara removed their assignment Mar 30, 2017
@mmalerba mmalerba merged commit f93778c into angular:datepicker Mar 30, 2017
mmalerba added a commit that referenced this pull request Apr 14, 2017
#3854)

* fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker

* add doc comments
mmalerba added a commit that referenced this pull request Apr 20, 2017
#3854)

* fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker

* add doc comments
mmalerba added a commit that referenced this pull request Apr 29, 2017
#3854)

* fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker

* add doc comments
mmalerba added a commit that referenced this pull request May 5, 2017
#3854)

* fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker

* add doc comments
mmalerba added a commit that referenced this pull request May 9, 2017
#3854)

* fix(datepicker): use input's min & max properites rather than custom ones on md-datepicker

* add doc comments
@mmalerba mmalerba deleted the dp-minmax branch April 3, 2018 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants