refactor(datepicker): move weekdays into table header #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Is this the last thing needed before it gets merged to master? |
jelbourn
approved these changes
Apr 19, 2017
src/lib/datepicker/month-view.ts
Outdated
| _weekdays: string[]; | ||
|
|
||
| constructor(private _locale: CalendarLocale) { | ||
| this._weekdays = this._locale.narrowDays.slice(this._locale.firstDayOfWeek) |
There was a problem hiding this comment.
Add a comment like
// Rotate the labels for days of the week based on the configured first day of the week.
src/lib/datepicker/calendar.scss
Outdated
| position: relative; | ||
| height: $mat-calendar-header-divider-width; | ||
|
|
||
| &::after { |
There was a problem hiding this comment.
Add a comment explaining what the ::after is used for?
mmalerba
added a commit
that referenced
this pull request
Apr 20, 2017
* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments
mmalerba
added a commit
that referenced
this pull request
Apr 29, 2017
* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments
mmalerba
added a commit
that referenced
this pull request
May 5, 2017
* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments
mmalerba
added a commit
that referenced
this pull request
May 9, 2017
* fix broken tests * md-calendar-table --> [md-calendar-body] * move md-calendar-body to tbody element * move weekdays into table header * finishing touches * fix year view padding * add some comments
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.