Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): tab opening multiple select and space scrolling page #4210

Merged
merged 3 commits into from
Apr 28, 2017
Merged

fix(select): tab opening multiple select and space scrolling page #4210

merged 3 commits into from
Apr 28, 2017

Conversation

crisbeto
Copy link
Member

  • Fixes pressing tab (or any other key, except arrows) opening md-select in multiple mode.
  • Fixes the page getting scrolled down when opening a select by pressing space.
  • Adds missing test coverage for opening a multiple select with the arrow keys.

@crisbeto
fix(select): tab opening multiple select and space scrolling page
ec73bf8 
* Fixes pressing tab (or any other key, except arrows) opening `md-select` in `multiple` mode.
* Fixes the page getting scrolled down when opening a select by pressing space.
* Adds missing test coverage for opening a multiple select with the arrow keys.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2017
kara
kara approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from typo. Apply label when ready.

src/lib/core/testing/event-objects.ts Outdated
});
Object.defineProperty(event, 'keyCode', { get: () => keyCode });

// IE won't set `defaultPrevented` on syntetic events so we need to do it manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntetic -> synthetic

@kara kara removed their assignment Apr 26, 2017
@crisbeto crisbeto force-pushed the select-multiple-tab-through branch from 01f883e to b4ef15f Compare April 27, 2017 17:06
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 27, 2017
@mmalerba mmalerba merged commit 24a762f into angular:master Apr 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @kara @googlebot @mmalerba