Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slide-toggle): invalid model change event #4220

Merged
merged 3 commits into from
Jul 28, 2017
Merged

fix(slide-toggle): invalid model change event #4220

merged 3 commits into from
Jul 28, 2017

Commits on Jul 23, 2017

  1. fix(slide-toggle): invalid model change event (angular#4140)" (angula… 

    …r#4218)

While initially looking into angular#4124, there were a few more issues inside of the slide-toggle.

* ngModelChange event is dispatched at initialization.

* Checked state isn't synchronized when state changes through drag. New state after dragging got overwritten by click event on label.

* Removes unnecessary logic inside of `change` listener. Change event doesn't fire if underlying checkbox is disabled.

Fixes angular#4124.
    @devversion
    devversion committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    08699f1 View commit details
    Browse the repository at this point in the history

  2. Cast NgModel value to a boolean

    @devversion
    devversion committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    0365c7a View commit details
    Browse the repository at this point in the history

  3. Properly mark component for check

    @devversion
    devversion committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    36dea28 View commit details
    Browse the repository at this point in the history