fix(radio-button): Radio buttons are not tab stops in Safari

[trik]

No description provided.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[trik]

I signed it!

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[robertmesserle]

Thanks for your contribution! However, this issue was fixed as part of this PR: #415

[trik]

@robertmesserle what about this one? d56946a

sorry, i had to make a different pr, it refers #327

[robertmesserle]

@trik We do still need a fix for this, but when I tried applying that commit to master and running the tests, it doesn't appear to fix the bug. Were there other changes in one of the other commits required to make this work?

[trik]

@robertmesserle no, only that one.. why it doesn't fix? in then unit test i set a value for the radio group model and i get one button selected, then i set the model to null and all buttons are de-selected

[robertmesserle]

The failure I get is on the test you added. It needed the following line:

this._radios.forEach(radio => radio.checked = false);

Without that, it never actually unchecked any of the child radio buttons.

[robertmesserle]

Ah, I see why your tests weren't failing. Your tests were never running.

There was a bug in the radio button tests where fakeAsync was wrapped around a function, which returns a new function - but that new function is never called. So your tests would have passed regardless of what they checked. (This was an issue with all tests in radio-button and is being fixed now by @jelbourn).

There were some other changes required to make this work as well. I'll open a PR with the working changes and mention you in it.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}