Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(universal): gate platform checks on being on browser #4635

Merged
merged 1 commit into from
May 19, 2017
Merged

fix(universal): gate platform checks on being on browser #4635

merged 1 commit into from
May 19, 2017

Conversation

jelbourn
Copy link
Member

Related to #308

@jelbourn jelbourn requested a review from mmalerba May 18, 2017 00:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 18, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 18, 2017
@jelbourn jelbourn merged commit e4c7601 into angular:master May 19, 2017
@azerafati azerafati mentioned this pull request May 21, 2017
Closed
@jelbourn jelbourn deleted the universal-platform branch September 13, 2017 04:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @mmalerba @googlebot