Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): add disableClose option #4842

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

  • Adds the ability to prevent users from closing a menu via the disableClose option.
  • Fixes an exception that was being thrown when tabbing through menu items multiple times.

* Adds the ability to prevent users from closing a menu via the `disableClose` option.
* Fixes an exception that was being thrown when tabbing through menu items multiple times.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 27, 2017
@willshowell
Copy link
Contributor

I believe this fixes #2612

@jelbourn
Copy link
Member

Chatted w/ @kara about this and we decided that we don't want to add this as a feature to md-menu. This is largely because turning it on would be detrimental to the a11y experience (see https://www.w3.org/TR/wai-aria-practices-1.1/#menu), and we want to generally avoid adding APIs that go counter to a11y best practices.

@nolisj
Copy link

nolisj commented Aug 30, 2017

That link (https://www.w3.org/TR/wai-aria-practices-1.1/#menu) doesn't seem to indicate that we are not allowed to retain the menu when we click one of its child menus. On the contrary, the last statement below is an indication that it is allowed.

"A menu is usually opened, or made visible, by activating a menu button, choosing an item in a menu that opens a sub menu, or by invoking a command, such as Shift + F10 in Windows, that opens a context specific menu. When a user activates a choice in a menu, the menu usually closes unless the choice opened a submenu."

@alua1612
Copy link

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants