feat(overlay): add connected overlay directive #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| }); | ||
| } | ||
|
|
||
| /** Destroys the overlat created by this directive. */ |
|
Added a few questions, but LGTM. |
jelbourn
force-pushed
the
overlay-directive
branch
from
f045e81
to
83b40d4
Compare
|
@justindujardin @kara addressed comments |
jelbourn
force-pushed
the
overlay-directive
branch
from
83b40d4
to
2cf7f68
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara @hansl
This is the initial version of the final part blocking things like menus and select. It's a directive that creates an overlay from the content in a template and positions it connected to some other element.