fix(input,cdk): a couple of server-side rendering errors #5066
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
5064/ssr-errors
branch
from
a42c915
to
0f5dbfe
Compare
|
@jelbourn The |
crisbeto
force-pushed
the
5064/ssr-errors
branch
from
0f5dbfe
to
ba20454
Compare
* Fixes an error that is thrown during server-side rendering if an input has a `type`. * Fixes an error that was being thrown by the `cdkObserveContent` due to the lack of a `MutationObserver`.
crisbeto
force-pushed
the
5064/ssr-errors
branch
from
ba20454
to
32ace1c
Compare
src/lib/input/input-container.ts
Outdated
| @@ -267,7 +268,8 @@ export class MdInputDirective { | |||
| /** Determines if the component host is a textarea. If not recognizable it returns false. */ | |||
| private _isTextarea() { | |||
| let nativeElement = this._elementRef.nativeElement; | |||
| return nativeElement ? nativeElement.nodeName.toLowerCase() === 'textarea' : false; | |||
| let nodeName = this._platform.isBrowser ? nativeElement.nodeName : nativeElement.name; | |||
There was a problem hiding this comment.
Should add a comment that explains why this falls back to name
(also shouldn't be necessary long-term since platform-server is changing to mimic more DOM APIs)
| @@ -86,7 +86,7 @@ | |||
| <h2>Datepicker</h2> | |||
|
|
|||
| <md-input-container> | |||
| <input mdInput [mdDatepicker]="birthday" placeholder="Birthday"> | |||
| <input type="text" mdInput [mdDatepicker]="birthday" placeholder="Birthday"> | |||
There was a problem hiding this comment.
Is there any problem with leaving the type empty?
There was a problem hiding this comment.
Not really, I left it in there to avoid regressions.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
type.cdkObserveContentdue to the lack of aMutationObserver.