Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: faster artifacts deploy script #5149

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

devversion
Copy link
Member

  • Improves the artifacts deploy script by not cloning the whole history of the build repositories (all tags, commits).
  • Less aggressive failing of the payload task if the previous payload is not uploaded (yet)

* Improves the artifacts deploy script by not cloning the whole history of the build repository (all tags, commits).
* Less aggressive failing of the payload task if the previous payload is not uploaded (yet)
@devversion devversion requested a review from jelbourn June 15, 2017 14:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is cool, we should also do it for the fetch-assets.sh script on the docs site.

Also, "Aggressive Failure" would be a good name for a band.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 15, 2017
@devversion
Copy link
Member Author

devversion commented Jun 15, 2017

Yeah I agree, I didn't even know about it until @ThomasBurleson showed it to me.

And yeah haha unfortunately I can't play any instrument! 😄 Maybe you can use it!

@kara kara merged commit f579ea1 into angular:master Jun 15, 2017
@devversion devversion deleted the build/faster-builds-clone branch June 15, 2017 21:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants