Add Initial Toggle Button #517
Conversation
googlebot
added
the
cla: no
|
CLAs look good, thanks! |
googlebot
added
cla: yes
| [checked]="checked" | ||
| [disabled]="disabled" | ||
| [name]="name" | ||
| (change)="onClick()"/> |
There was a problem hiding this comment.
We generally haven't been using the / at the end of void elements.
There was a problem hiding this comment.
Got it from radio, sorry about that! Should there be a space between " and > or does it not matter?
jelbourn
added
in progress
|
All comments addressed. |
iveysaur
added
pr: needs review
and removed
in progress
| value: any; | ||
| } | ||
|
|
||
| /** Exclusive selection button toggle group. */ |
There was a problem hiding this comment.
I'd expand this comment to include something like "Behaves like a radio-button group."
| } | ||
|
|
||
| md-button-toggle md-icon { | ||
| vertical-align: middle; |
There was a problem hiding this comment.
Would we want to do this for all direct children? Or just md-icon?
There was a problem hiding this comment.
I don't have a strong opinion, I just wanted to be safe for this iteration when I wrote that.
* Update comment * Remove unused `_buttonToggles` * Use string literals for button toggle type * Move instantiation into the constructor * Add `isSingleSelection` getter
* Exclusive toggle should deselect all when group value is cleared * Button toggles should be checked when the checkbox is interacted with
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @jelbourn @robertmesserle @kara
This is a start for the toggle buttons. Currently supports exclusive and multiple selection with styles and the disabled state. Exclusive selection has a value which is set to the selected toggle.
Still needs:
Design Doc