-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete): reopening when clicking an option in IE #5172
fix(autocomplete): reopening when clicking an option in IE #5172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apply label when typo is fixed.
@@ -78,7 +78,9 @@ export function getMdAutocompleteMissingPanelError(): Error { | |||
'[attr.aria-activedescendant]': 'activeOption?.id', | |||
'[attr.aria-expanded]': 'panelOpen.toString()', | |||
'[attr.aria-owns]': 'autocomplete?.id', | |||
'(focus)': 'openPanel()', | |||
// Note: we use `focusin`, as opposed to `focus`, in order to open the panel | |||
// a little earlier. This avoids issues where IE delays the focusing the input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: IE delays the focusing the input
-> IE delays the focusing of the input
Fixes an issue that caused IE to reopen the autocomplete panel if the user clicks to select an item. It seems that IE can delay refocusing the input after the panel has been closed, which causes the focus handler to reopen it. Fixes angular#5165.
08c7ae0
to
a763fd6
Compare
Caretaker note: one team has a test utility that fires a fake focus event and tests that the autocomplete is open; changing it to also do |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes an issue that caused IE to reopen the autocomplete panel if the user clicks to select an item. It seems that IE can delay refocusing the input after the panel has been closed, which causes the focus handler to reopen it.
Fixes #5165.