Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): role being set on the wrong element #5191

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

crisbeto
Copy link
Member

Currently, the menu role is set on the md-menu directive, however the it is inert and won't get rendered inside the overlay. These changes remove the menu role from the inert element and set it on the element that will get rendered inside the overlay.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Jun 18, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 18, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fixture.componentInstance.trigger.openMenu();
fixture.detectChanges();

expect(overlayContainerElement.querySelector('[role="menu"]'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we're not using getAttribute here to check directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a little shorter. I'll switch to a querySelector and getAttribute.

@kara kara removed their assignment Jun 19, 2017
Currently, the `menu` role is set on the `md-menu` directive, however the it is inert and won't get rendered inside the overlay. These changes remove the `menu` role from the inert element and set it on the element that will get rendered inside the overlay.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2017
@jelbourn jelbourn merged commit 2239668 into angular:master Jun 22, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants