Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: dgeni is building docs twice #5536

Merged
merged 1 commit into from
Jul 6, 2017
Merged

build: dgeni is building docs twice #5536

merged 1 commit into from
Jul 6, 2017

Conversation

devversion
Copy link
Member

@devversion
build: dgeni is building docs twice
8e4c47b 
* With angular#5429 dgeni runs twice when running the `gulp docs` command. This is because the dgeni generate function has been added to the `dgeni/index.js` file.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2017
@jelbourn
Copy link
Member

jelbourn commented Jul 6, 2017

Whoops, added that for debugging and forgot to remove it.

jelbourn
jelbourn approved these changes Jul 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 6, 2017
@mmalerba mmalerba merged commit e3f3233 into angular:master Jul 6, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
@devversion @amcdnl
build: dgeni is building docs twice (angular#5536)
b495631 
* With angular#5429 dgeni runs twice when running the `gulp docs` command. This is because the dgeni generate function has been added to the `dgeni/index.js` file.
@devversion devversion deleted the build/dgeni-building-twice branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba