tests(checkbox, slide-toggle): use fakeAsync instead of whenStable #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Most of the `whenStable()` promise calls can be replaced with the `flushMicrotasks` method, which just flushes them instead of waiting for them to really happen (when using `async`). * This reduces nesting of functions and also makes the tests in theory faster.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@jelbourn I will look for more instances like this in other components as well. This really makes tests more readable I feel like |
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
…ngular#5547) * Most of the `whenStable()` promise calls can be replaced with the `flushMicrotasks` method, which just flushes them instead of waiting for them to really happen (when using `async`). * This reduces nesting of functions and also makes the tests in theory faster.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenStable()promise calls can be replaced with theflushMicrotasksmethod, which just flushes them instead of waiting for them to really happen (when usingasync).