Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix rollup globals for examples package #5611

Merged

Conversation

devversion
Copy link
Member

Recently the rollup globals have been changed because the operators are no longer applied to the prototype (using /add/ imports).

This now causes some warnigns and invalid id's in the bundles of the Material examples because those still use the /add/ imports in some examples.

Note: In theory we can also generate this object automatically as well, but since those are less operator it should be fine.

@jelbourn In the future I think it would be better if we also have a rollup-config.js file for every package? (as in Angular core)

Recently the rollup globals have been changed because the operators are no longer applied to the prototype (using `/add/` imports).

This now causes some warnigns and invalid id's in the bundles of the Material examples because those still use the `/add/` imports in some examples.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 8, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't see any harm in having this one config for all the package since it doesn't have any effect if you don't use the symbol.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 8, 2017
@mmalerba mmalerba merged commit 077ebf6 into angular:master Jul 9, 2017
@devversion devversion deleted the build/fix-rollup-warning-examples-rxjs branch July 9, 2017 06:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants