fix(dialog): better handling of custom ViewContainerRef with OnPush change detection #6164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markForCheck
call after starting the dialog animation, in order to ensure that it animates away if it was opened from a component with OnPush change detection.markForCheck
, these changes switch to starting the backdrop animation together with the dialog animation. This avoids some slight timing issues where the backdrop can start its animation a little too early.completed
callback in theMdDialogRef
.The dialog changes should solve issues like #5118.
@mmalerba I've reverted the changes from #6026 since it should work correctly with the
ViewContainerRef
now.