-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select,autocomplete): darken selected option #6302
fix(select,autocomplete): darken selected option #6302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -30,7 +30,7 @@ | |||
|
|||
// In multiple mode there is a checkbox to show that the option is selected. | |||
&.mat-selected:not(.mat-option-multiple) { | |||
background: mat-color($background, hover); | |||
background: rgba(mat-color($background, hover), 0.12); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi mat-color
should take opacity as a third argument, but it's the same either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that initially and I kept getting some weird SASS error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, it works now. It must've been something else.
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered. Fixes angular#6229.
413bdc0
to
bef4e76
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Darkens the selected option background in order to distinguish it from the ones that are focused or hovered.
Fixes #6229.