Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): error if triggerValue is accessed from an empty select #6575

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

crisbeto
Copy link
Member

Fixes an error that was thrown if the triggerValue is accessed on a md-select that doesn't have a selected value, because the triggerValue assumed that there would always be a value.

Fixes an error that was thrown if the `triggerValue` is accessed on a `md-select` that doesn't have a selected value, because the `triggerValue` assumed that there would always be a value.
@crisbeto crisbeto requested a review from kara as a code owner August 21, 2017 19:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Aug 22, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed cla: yes PR author has agreed to Google's Contributor License Agreement pr: needs review labels Aug 22, 2017
@kara kara merged commit 0526689 into angular:master Aug 23, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants