Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): placeholder text is hidden by parent visibility #680

Merged
merged 1 commit into from
Jun 20, 2016
Merged

fix(input): placeholder text is hidden by parent visibility #680

merged 1 commit into from
Jun 20, 2016

Conversation

robertmesserle
Copy link
Contributor

@robertmesserle robertmesserle commented Jun 13, 2016

Previously, adding visibility: hidden to a parent element would not hide the placeholder text for md-input.

Closes #670

R: @hansl @jelbourn

Previously, adding `visibility: hidden` to a parent element would not hide the placeholder text for inputs.

Closes #670
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 13, 2016
@robertmesserle
Copy link
Contributor Author

@hansl Doesn't look like there were any transitions used on visibility: hidden, seems identical with display: none

@hansl
Copy link
Contributor

hansl commented Jun 16, 2016

If you don't see any problems, then LGTM :)

@jelbourn jelbourn merged commit b407278 into angular:master Jun 20, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input placeholder is not hiding if parent's visibility:hidden;
4 participants