Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: parallel secondary entry-points building #6822

Conversation

devversion
Copy link
Member

All secondary entry-points of the CDK are no longer built sequentially. Secondary entry-points will be resolved in batches that can be compiled in parallel.

For example:

[
  [ 'coercion', 'platform', 'rxjs', 'keycodes', 'bidi', 'collections', 'portal' ],
  [ 'a11y', 'observers', 'scrolling', 'stepper', 'table' ],
  [ 'overlay'
]

This should improve the build time of the CDK package.

Note: Shouldn't be really important (because of Bazel), but it shouldn't cause merge conflicts either and it was something I played with a long time ago.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2017
@devversion devversion force-pushed the build/parallel-building-entry-points branch from c96fff7 to b26ce62 Compare September 3, 2017 16:16
All secondary entry-points of the CDK are no longer built sequentially. Secondary entry-points will be resolved in batches that can be compiled in parallel.

For example:
```
[
  [ 'coercion', 'platform', 'rxjs', 'keycodes', 'bidi', 'collections', 'portal' ],
  [ 'a11y', 'observers', 'scrolling', 'stepper', 'table' ],
  [ 'overlay'
]
```

This should improve the build time of the CDK package.
@devversion devversion force-pushed the build/parallel-building-entry-points branch from b26ce62 to 3d946b1 Compare September 3, 2017 18:13
@jelbourn
Copy link
Member

jelbourn commented Sep 5, 2017

Did this make any difference in build time for you? On my machine is ended up being about the same.

@devversion
Copy link
Member Author

@jelbourn True. There is not much of a difference here. I got a 4-5 seconds speed boost due to this change on Windows, but I assume that this is varying anyway.

It looks like calling the NGC using @angular/tsc-wrapped blocks the process, which then behaves similar as sequential building.

Feel free to close this PR. It doesn't really make a big difference.

@jelbourn
Copy link
Member

jelbourn commented Sep 5, 2017

4 - 5 seconds is pretty huge- is that consistent? My build is consistently ~12 seconds with and without this PR

@devversion
Copy link
Member Author

Not really. As I said it's varying a lot.

Sometimes it's equal to the old time, but sometimes it's also faster (e.g. 4sec). But to be honest I think that more relates to the whole setup (e.g if dist/ is cleared already; if there is disk work in progress)

@devversion devversion added the P4 A relatively minor issue that is not relevant to core functions label Sep 6, 2017
@devversion devversion closed this Sep 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants