Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider, drawer): unsubscribe from directionaly change subject #6907

Merged
merged 1 commit into from
Sep 8, 2017
Merged

fix(slider, drawer): unsubscribe from directionaly change subject #6907

merged 1 commit into from
Sep 8, 2017

Commits on Sep 7, 2017

  1. fix(slider, drawer): unsubscribe from directionaly change subject 

    If a slider component will be destroyed, the `ngOnDestroy` hook calls `_directionality.change.unsubscribe()`, which means that the `unsubscribe` method is called on the `EventEmitter` instead of the actual `Subscription`. This causes the `EventEmitter` to be kind of "completed", which then means that there will be errors if `emit()` is called again (https://github.com/ReactiveX/rxjs/blob/master/src/Subject.ts#L96).

Also fixes that the drawer never unsubscribes from the `_dir.change` `EventEmitter`. This means that even if the component is destroyed, whenever the directionality changes, the drawer calls `validateDrawers()`.

Fixes angular#6892. Fixes angular#6903.
    @devversion
    devversion committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    a15a9fa View commit details
    Browse the repository at this point in the history