Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(selection-list): add selectAll and deselectAll functions #6971

Merged
merged 1 commit into from
Sep 12, 2017
Merged

feat(selection-list): add selectAll and deselectAll functions #6971

merged 1 commit into from
Sep 12, 2017

Conversation

crisbeto
Copy link
Member

  • Adds the ability to select and deselect all options at once.
  • Adds a demo of the selection list to the demo app.
  • Fixes an issue that caused the checkbox inside the selection list to collapse.
  • Sets the proper cursor on the list items.

Fixes #6969.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2017
jelbourn
jelbourn approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

@crisbeto just one lint error

@crisbeto
Copy link
Member Author

That's the one that'll be fixed by #6956 @jelbourn.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2017
@crisbeto
feat(selection-list): add selectAll and deselectAll functions
8c29bc6 
* Adds the ability to select and deselect all options at once.
* Adds a demo of the selection list to the demo app.
* Fixes an issue that caused the checkbox inside the selection list to collapse.
* Sets the proper cursor on the list items.

Fixes angular#6969.
@crisbeto crisbeto force-pushed the 6969/selection-list-select-all branch from 31f4757 to 8c29bc6 Compare September 11, 2017 18:36
@mmalerba mmalerba merged commit dc9679d into angular:master Sep 12, 2017
@dereekb dereekb mentioned this pull request Sep 12, 2017
Merged
josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 15, 2017
@crisbeto @josephperrott
feat(selection-list): add selectAll and deselectAll functions (angula…
c9b14f2 
…r#6971)

* Adds the ability to select and deselect all options at once.
* Adds a demo of the selection list to the demo app.
* Fixes an issue that caused the checkbox inside the selection list to collapse.
* Sets the proper cursor on the list items.

Fixes angular#6969.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[md-selection-list] selectAll function
4 participants
@crisbeto @jelbourn @googlebot @mmalerba