-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chips): update API per #6677 #7030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just having selectionChange
capture both selected
and deselected
?
These selection list changes are probably relevant: #6901 |
@jelbourn - I like that much better. Updated. What about |
|
@jelbourn - It was unclear to me how it differs from |
@amcdnl could you please rebase? |
This has diverged so much, I'm going to redo this in a new PR. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Addresses #6677 for Chips
Changes:
select
toselectionChange
deselect
todeselected
- @jelbourn - what do you think about making thisdeselection
?destroy
todestroyed
remove
toremoved