chore(dialog): add generic param for config data #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
4398/dialog-generic
branch
from
2e41711
to
a1c6b56
Compare
jelbourn
reviewed
Oct 6, 2017
| @@ -23,7 +23,7 @@ export interface DialogPosition { | |||
| /** | |||
| * Configuration for opening a modal dialog with the MatDialog service. | |||
| */ | |||
| export class MatDialogConfig { | |||
| export class MatDialogConfig<D = any> { | |||
There was a problem hiding this comment.
Doesn't this require TS 2.3 or 2.4?
jelbourn
added
pr: lgtm
action: merge
|
We may use 2.4, but I don't think we ever officially said that we require greater than 2.2. Can you add a |
Adds a generic parameter to the `MatDialogConfig` that indicates the type of its `data`. BREAKING CHANGE: Material now requires at least TypeScript 2.4. Fixes angular#4398.
crisbeto
force-pushed
the
4398/dialog-generic
branch
from
a1c6b56
to
544ac12
Compare
|
Updated. |
|
According to this comment, the core team recommends the use of More precisely: |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic parameter to the
MatDialogConfigthat indicates the type of itsdata.BREAKING CHANGE: Material now requires at least TypeScript 2.4.
Fixes #4398.