Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chips): Use all available space for the input #7462

Merged
merged 1 commit into from
Nov 20, 2017
Merged

feat(chips): Use all available space for the input #7462

merged 1 commit into from
Nov 20, 2017

Conversation

ppham27
Copy link
Contributor

@ppham27 ppham27 commented Oct 2, 2017

Currently, an input inside a chips list is limited to 150px, so it looks like this.

Cutoff Name.

Adding flex lets the input use all available space and still wrap correctly.

Using all avaible space

Wrapping

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2017
@ppham27 ppham27 force-pushed the chips-flex branch 2 times, most recently from 025e85f to 3b8c76f Compare October 4, 2017 06:14
tinayuangao
tinayuangao approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppham27 ppham27 force-pushed the chips-flex branch 6 times, most recently from 09bbd14 to 5d031ea Compare October 17, 2017 19:25
@ppham27 ppham27 force-pushed the chips-flex branch 2 times, most recently from 76c857f to f354ca2 Compare October 28, 2017 20:11
@tinayuangao tinayuangao added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2017
@angular angular deleted a comment from listepo-alterpost Nov 20, 2017
@jelbourn jelbourn merged commit c725249 into angular:master Nov 20, 2017
@ppham27 ppham27 deleted the chips-flex branch November 20, 2017 19:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ppham27 @tinayuangao @jelbourn @googlebot @josephperrott